Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adds info about restore and backup/repair tasks interference #4124

Merged
merged 1 commit into from
Dec 11, 2024
Merged

docs: adds info about restore and backup/repair tasks interference #4124

merged 1 commit into from
Dec 11, 2024

Conversation

VAveryanov8
Copy link
Collaborator

@VAveryanov8 VAveryanov8 commented Nov 25, 2024 •
edited
Loading

This extends restore procedure docs with how to avoid conflicts between restore and backup/repair tasks in a cluster.

Fixes: #3742

Please make sure that:

  • Code is split to commits that address a single change
  • Commit messages are informative
  • Commit titles have module prefix
  • Commit titles have issue nr. suffix

@VAveryanov8 VAveryanov8 marked this pull request as ready for review November 26, 2024 15:29
@VAveryanov8
Copy link
Collaborator Author

I'm not sure which SM version will contain changes made in #4122, so I've put 3.5 version in the docs temporarily.

@Michal-Leszczynski
Copy link
Collaborator

I'm not sure which SM version will contain changes made in #4122, so I've put 3.5 version in the docs temporarily.

3.5 is a good candidate - we shouldn't put it into 3.4.1 as this is a feature.

@Michal-Leszczynski
Copy link
Collaborator

For docs oriented PRs, It's always good to request a review from someone from the product team (e.g. @annastuchlik). They don't always have the time to go through it, so not all docs related PRs need their approval.

@VAveryanov8 VAveryanov8 force-pushed the va/docs-restore-and-other-tasks branch from 533c285 to 74a3414 Compare December 3, 2024 11:49
@Michal-Leszczynski
Copy link
Collaborator

@VAveryanov8 is this PR ready for re-review?
In general, if you wait for my re-review, it will be faster if you request the re-review in the reviewers section on github or by pinging me directly.

@VAveryanov8 VAveryanov8 changed the title feat(docs): adds info about restore and backup/repair tasks interference docs: adds info about restore and backup/repair tasks interference Dec 3, 2024
@VAveryanov8
Copy link
Collaborator Author

@Michal-Leszczynski btw: do we use labels to set the target version for PRs?

@Michal-Leszczynski
Copy link
Collaborator

@Michal-Leszczynski btw: do we use labels to set the target version for PRs?

In theory we should. I was talking about it during our meeting, but then I figured that if we stick to SEMVER, then patch releases would be really rare for SM, so hand picking commits for them does not seem that bad.

Michal-Leszczynski
Michal-Leszczynski approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@Michal-Leszczynski Michal-Leszczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Michal-Leszczynski Michal-Leszczynski mentioned this pull request Dec 10, 2024
Merged
@Michal-Leszczynski
Copy link
Collaborator

@VAveryanov8 the other PR documenting previous behavior has been merged.
Please rebase this one so it can be merged as well.

@VAveryanov8 VAveryanov8 force-pushed the va/docs-restore-and-other-tasks branch from 74a3414 to 53166ea Compare December 10, 2024 16:08
@VAveryanov8
chore(docs): how to avoid restore and backup/repair task interference (…
cafd48d 
…#4147)

This documents how to prevent interference between restore and backup/repair
tasks.

Fixes: #3742
@VAveryanov8 VAveryanov8 force-pushed the va/docs-restore-and-other-tasks branch from 53166ea to cafd48d Compare December 10, 2024 16:19
@VAveryanov8 VAveryanov8 merged commit 1b7dc91 into master Dec 11, 2024
52 checks passed
@VAveryanov8 VAveryanov8 deleted the va/docs-restore-and-other-tasks branch December 11, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michal-Leszczynski Michal-Leszczynski Michal-Leszczynski approved these changes

@karol-kokoszka karol-kokoszka Awaiting requested review from karol-kokoszka karol-kokoszka is a code owner

@annastuchlik annastuchlik Awaiting requested review from annastuchlik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Issue in page Restore
2 participants
@VAveryanov8 @Michal-Leszczynski